Update for filtering #314
Merged
Update for filtering #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is wired up via a new config option "post_filters". Post filtering happens BEFORE prune, so they get run before conservative/liberal pruning happens, which essentially needs be last to make sense.
Added DEFAULT_POST_FILTERS to remove NUKE pseudo-nodes and Program nodes. Added transform_sexp to transform top-level :body node to NUKE. Wrapped the top level sexp so the whole tree gets processed. This is probably a bug in CCD and/or flay.
I am completely OK if this doesn't make it in. I'm not sure how to reduce it more to make it un-gross.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the post-filtering from flay 2.11 into CCFlay and hooks it up via separate config. It also adds a rewrite layer for javascript and improves javascript's filters to reduce idiomatic false positives.